Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS packaging: Fix microphone access by adding NSMicrophoneUsageDescription #11367

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Mar 14, 2023

Fixes #11365

On recent macOS versions Apple requires applications to provide a usage description, otherwise the app will not even ask for permission and microphone-related features will not work. This fixes it by adding such a description, which is presented at first launch:

Screenshot 2023-03-14 at 13 43 10

cc @daschuer

@daschuer
Copy link
Member

Cool, thank you. Can you rebase this to 2.3?

@daschuer daschuer added this to the 2.3.5 milestone Mar 14, 2023
@fwcd fwcd changed the base branch from main to 2.3 March 14, 2023 14:39
@fwcd
Copy link
Member Author

fwcd commented Mar 14, 2023

Done!

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@daschuer daschuer merged commit 63819c1 into mixxxdj:2.3 Mar 14, 2023
@fwcd fwcd deleted the fix-mic-permission-macos branch March 14, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixxx snapshots do not ask for microphone access on macOS (regression)
2 participants